This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: eth_getTransactionByBlockNumberAndIndex and eth_getTransactionByBlockHashAndIndex to respect non-zero transaction index
#3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lockHashAndIndex to allow non-zero transaction index, fixes 3118
jeffsmale90
changed the title
davidmurdoch
approved these changes
May 23, 2022
davidmurdoch
changed the title
eth_getTransactionByBlockNumberAndIndex and eth_getTransactionByBlockHashAndIndex to allow non-zero transaction index
jeffsmale90
changed the title
eth_getTransactionByBlockNumberAndIndex and eth_getTransactionByBlockHashAndIndex to allow non-zero transaction indexeth_getTransactionByBlockNumberAndIndex and eth_getTransactionByBlockHashAndIndex to respect non-zero transaction index
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously both
eth_getTransactionByBlockNumberAndIndexandeth_getTransactionByBlockHashAndIndexwould incorrectly return the first transaction in the block, regardless of the value passed asindex.With this fix, any transaction can be retrieved by providing its index within the given block.